-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment-agnostic scripts for running ctests and pytests #2165
Merged
rapids-bot
merged 12 commits into
rapidsai:branch-24.04
from
trxcllnt:fea/generic-test-scripts
Feb 27, 2024
Merged
Add environment-agnostic scripts for running ctests and pytests #2165
rapids-bot
merged 12 commits into
rapidsai:branch-24.04
from
trxcllnt:fea/generic-test-scripts
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
added
enhancement
New feature or request
3 - Ready for Review
non-breaking
Non-breaking change
labels
Feb 7, 2024
trxcllnt
added
improvement
Improvement / enhancement to an existing function
and removed
enhancement
New feature or request
labels
Feb 7, 2024
…nto fea/generic-test-scripts
AyodeAwe
approved these changes
Feb 21, 2024
It looks like the c++ tests are running so yeah that's fine |
/merge |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
ci
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds environment-agnostic
run_*_{ctests,pytests}.sh
scripts, and updatestest_*_{cpp,python}.sh
to call them.The
test_*_{cpp,python}.sh
scripts assume they're running in our CI environment, and they do more than just run the tests.This PR allows devs and downstream consumers to only run the tests, and skip the unrelated logic in
test_*_{cpp,python}.sh
.