Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace call to mr::get_mem_info() #2099

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

harrism
Copy link
Member

@harrism harrism commented Jan 17, 2024

In the near future memory resources will no longer have get_mem_info().

There is one place in RAFT that uses this. This PR replaces it with rmm::available_device_memory() which just calls cudaMemGetInfo().

@harrism harrism requested a review from a team as a code owner January 17, 2024 20:02
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 17, 2024
@github-actions github-actions bot added cpp and removed improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 17, 2024
@harrism harrism self-assigned this Jan 17, 2024
@harrism harrism requested a review from achirkin January 17, 2024 20:03
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 18, 2024
@harrism
Copy link
Member Author

harrism commented Jan 18, 2024

Accidentally pushed some changes that need to happen after an RMM PR merges. Reverted.

Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! LGTM

@cjnolet
Copy link
Member

cjnolet commented Jan 18, 2024

/merge

@rapids-bot rapids-bot bot merged commit 7cab0c3 into rapidsai:branch-24.02 Jan 18, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants