Allow topk larger than 1024 in CAGRA #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows CAGRA search to have an arbitrarily large top-k, instead of being limited to 1024 like in the previous code. This works by using the multi-kernel search path, and replacing the _cuann_find_topk code with the matrix::select_k code - which can handle large K values.
benfred
changed the title
benfred
added
improvement
tfeher
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks @benfred for the PR! Overall it looks good: while the extra copies are not ideal (and we should add it to a tracker to improve that), it alleviates the max-k problem without affecting the perf where k< 1024. Just one comment below.
cpp/include/raft/neighbors/detail/cagra/search_multi_kernel.cuh
Outdated
Show resolved
Hide resolved
|
/merge |
abc99lr
pushed a commit
to abc99lr/raft
that referenced
this pull request
Jan 23, 2024
This reverts commit 0586fc3.
abc99lr
pushed a commit
to abc99lr/raft
that referenced
this pull request
Jan 23, 2024
This reverts commit fdd4ad2.
cjnolet
added a commit
to cjnolet/raft
that referenced
this pull request
Feb 8, 2024
This reverts commit 0586fc3.
raydouglass
pushed a commit
that referenced
this pull request
Feb 9, 2024
RAFT C++ tests were not running for a portion of the 24.02 development cycle, until the merger of rapidsai/rapids-cmake#533. This PR fixes some failing tests and reverts PRs that caused test failures that were silent until now, specifically #2097 and #2085. These features will be revisited in a subsequent release. Authors: - Malte Förster (https://github.com/mfoerste4) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Ben Frederickson (https://github.com/benfred) - Bradley Dice (https://github.com/bdice)
benfred
added a commit
to benfred/raft
that referenced
this pull request
Feb 13, 2024
Reapply changes from rapidsai#2097 This change allows CAGRA search to have an arbitrarily large top-k, instead of being limited to 1024 like in the previous code. This works by using the multi-kernel search path, and replacing the _cuann_find_topk code with the matrix::select_k code - which can handle large K values.
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
Reapply changes from #2097 This change allows CAGRA search to have an arbitrarily large top-k, instead of being limited to 1024 like in the previous code. This works by using the multi-kernel search path, and replacing the _cuann_find_topk code with the matrix::select_k code - which can handle large K values. Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #2181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows CAGRA search to have an arbitrarily large top-k, instead of being limited to 1024 like in the previous code.
This works by using the multi-kernel search path, and replacing the _cuann_find_topk code with the matrix::select_k code - which can handle large K values.