Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly taking ownership of nccl subcomm (and destroying it) #2094

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Properly taking ownership of nccl subcomm (and destroying it) #2094

merged 2 commits into from
Jan 12, 2024

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jan 11, 2024

No description provided.

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Jan 11, 2024
@cjnolet cjnolet self-assigned this Jan 11, 2024
@cjnolet cjnolet requested a review from a team as a code owner January 11, 2024 23:18
@github-actions github-actions bot added the cpp label Jan 11, 2024
ChuckHastings
ChuckHastings reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will test in my branch before approving.

cpp/include/raft/comms/detail/std_comms.hpp Outdated Show resolved Hide resolved
@ChuckHastings
Copy link
Contributor

This clears up the customer problem I was chasing, Thanks!

@ChuckHastings
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 7d5bb3c into rapidsai:branch-24.02 Jan 12, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@cjnolet cjnolet

Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjnolet @ChuckHastings