Removing code that explicitly compares equality of rmm memory resources #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
divyegala
approved these changes
Dec 7, 2023
… only be using workspace resource and current device resource internally to the code
divyegala
reviewed
Dec 7, 2023
| @@ -1634,7 +1617,7 @@ void extend(raft::resources const& handle, | |||
| } | |||
| if (size_factor * max_batch_size > free_mem) { | |||
| // if that still doesn't fit, resort to the UVM | |||
| batches_mr = &managed_memory; | |||
| batches_mr = device_memory; | |||
There was a problem hiding this comment.
This if-else now feels a little redundant, doesn't it?
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.