Add brute_force index serialization #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
added
3 - Ready for Review
feature request
Co-authored-by: Ben Frederickson <[email protected]>
Co-authored-by: Ben Frederickson <[email protected]>
benfred
reviewed
Dec 4, 2023
Co-authored-by: Ben Frederickson <[email protected]>
|
Thanks @benfred! Agreed with all the suggestions and updated accordingly. |
benfred
approved these changes
Dec 4, 2023
cjnolet
requested changes
Dec 4, 2023
There was a problem hiding this comment.
I think this looks really good and we've needed this! Just one thing- we've addressed this in other indices which require the original dataset available and I'd like to use the same design pattern here so that the dataset doesn't need to always be serialized out with the norms.
wphicks
added
4 - Waiting on Reviewer
|
I think there's a small failure in the docs build, but otherwise it looks great! |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add serialization and deserialization methods for brute_force index. Also add overloads to brute_force search and build functions taking index_param and search_param arguments for API compatibility with other index types.