Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax ucx pinning #1927

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Relax ucx pinning #1927

merged 2 commits into from
Oct 25, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 25, 2023

The latest builds of libarrow are built against ucx 1.15, so the upper bound constraint in raft is causing failures downstream when conda tries to solve environments containing both raft-dask and other packages that transitively bring in ucx via libarrow (namely cudf). This PR also bumps the minimum requirement to 1.14.1 to match ucx-py.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 25, 2023
@vyasr vyasr self-assigned this Oct 25, 2023
@vyasr vyasr requested a review from a team as a code owner October 25, 2023 00:12
@vyasr
Copy link
Contributor Author

vyasr commented Oct 25, 2023

For an example of such an error, see https://github.com/rapidsai/cuml/actions/runs/6631385329/job/18021706812

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, I've left a request just to make it consistent with UCX-Py.

conda/recipes/raft-dask/conda_build_config.yaml Outdated Show resolved Hide resolved
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vyasr !

@vyasr
Copy link
Contributor Author

vyasr commented Oct 25, 2023

/merge

@rapids-bot rapids-bot bot merged commit c95d821 into rapidsai:branch-23.12 Oct 25, 2023
57 checks passed
@vyasr vyasr deleted the chore/update_ucx branch October 25, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants