Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic entry-points from raft-ann-bench #1910

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

benfred
Copy link
Member

@benfred benfred commented Oct 18, 2023

Building raft-ann-bench can throw a

  distutils.errors.DistutilsOptionError: No configuration found for dynamic 'entry-points'.
  Some dynamic fields need to be specified via `tool.setuptools.dynamic`
  others must be specified via the equivalent attribute in `setup.py`.

error sometimes depending on distutils version.

This is becase we were specifying dynamic=entry-points, but not including the relevant tool.setuptools.dynamic section in pyproject.toml. Remove this to allow building

Building raft-ann-bench can throw a

```
  distutils.errors.DistutilsOptionError: No configuration found for dynamic 'entry-points'.
  Some dynamic fields need to be specified via `tool.setuptools.dynamic`
  others must be specified via the equivalent attribute in `setup.py`.
```

error sometimes depending on distutils reversion.

This is becase we were specifying dynamic entry-points, but not including
the relevant `tool.setuptools.dynamic` section in pyproject.toml. Remove this
to allow building
@benfred benfred requested a review from a team as a code owner October 18, 2023 16:28
@benfred benfred added bug Something isn't working non-breaking Non-breaking change and removed python labels Oct 18, 2023
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet
Copy link
Member

cjnolet commented Oct 19, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6fdb886 into rapidsai:branch-23.12 Oct 19, 2023
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

2 participants