-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Googletests and re-enabling in CI #1904
Fixing Googletests and re-enabling in CI #1904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add cd "$CONDA_PREFIX"/bin/gtests/libraft
before the ctest
line to have ctest execute the tests instead of reverting the change
It turns out at least the expanded Euclidean issue is related to the precision of clamping from round-off errors between the subtraction of the norms and the dot product (there can be an error of 1e-5, for example, which would end up becoming 0.003 once the sqrt is taken. Thus tiny errors get magnified from the sqrt. Prior to this change, we were just taking any small value < 1e-4 and clamping it to 0. The problem is that we were limiting the effective range of inputs to the algorithms. This change adds an explicit check that the norms are equal as well. Be cautioned that in order to determine the vectors are equal, we need to test that the dot product = normX = normY. The challenge is that this roundoff error makes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
/merge |
Recently, the CI script to run the C++ gtests was changed to call
ctest
but it looks like this command has been failing in CI for quite some time. It's a little scary as most of RAFT's C++ APIs are not exposed through Python and so we cannot rely on those Python tests to guarantee quality of the C++ APIs.I'm reverting the change back to invoking the C++ binaries directly so that we can get the tests running again. Once we figure out why
ctest
isn't running the tests then we can make the change to use that again.