-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all cuda kernels have hidden visibility #1898
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-23.12
from
robertmaynard:fea/hide_visibility_of_kernel_launches
Oct 13, 2023
Merged
Make all cuda kernels have hidden visibility #1898
rapids-bot
merged 5 commits into
rapidsai:branch-23.12
from
robertmaynard:fea/hide_visibility_of_kernel_launches
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
New feature or request
non-breaking
Non-breaking change
labels
Oct 12, 2023
robertmaynard
force-pushed
the
fea/hide_visibility_of_kernel_launches
branch
from
October 12, 2023 18:39
e630d0f
to
76b3508
Compare
Effect on binary size of libraft.a 23.12: 133361630 pr: 129748904 Effect on binary size of libraft.so 23.12: 83603224 pr: 83873088
robertmaynard
force-pushed
the
fea/hide_visibility_of_kernel_launches
branch
from
October 13, 2023 14:02
5649047
to
1c4d149
Compare
cjnolet
approved these changes
Oct 13, 2023
/merge |
divyegala
pushed a commit
to divyegala/raft
that referenced
this pull request
Oct 17, 2023
Effect on binary size of libraft.a 23.12: 133361630 pr: 129748904 Effect on binary size of libraft.so 23.12: 83603224 pr: 83873088 Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effect on binary size of libraft.a
23.12: 133361630
pr: 129748904
Effect on binary size of libraft.so
23.12: 83603224
pr: 83873088