[FEA] Helpers for identifying contiguous layouts. #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
changed the title
trivialfis
added
enhancement
divyegala
reviewed
Oct 11, 2023
| { | ||
| std::uint64_t stride = 1; | ||
| for (auto r = extents.rank(); r > 0; r--) { | ||
| if (stride != strides[r - 1]) { return false; } |
There was a problem hiding this comment.
In your test case, in the first iteration isn't stride = 1 and strides[r - 1] = 8 where r = 3? I don't understand how this doesn't exit in the first iteration itself
cpp/test/core/mdspan_utils.cu
Outdated
| { | ||
| extents<std::int64_t, dynamic_extent, dynamic_extent, dynamic_extent> exts{10, 10, 10}; | ||
| { | ||
| std::array<std::size_t, 3> strides{128, 32, 8}; |
There was a problem hiding this comment.
Shouldn't this be {800, 80, 8}? I must be really misunderstanding something here
|
@divyegala Apologies for the error, I got a bit confused now that I pick up the PR, how did I get the tests to pass (along with CI) ...
|
divyegala
approved these changes
Oct 12, 2023
|
/merge |
divyegala
pushed a commit
to divyegala/raft
that referenced
this pull request
Oct 17, 2023
- Use strides to determine whether we can use a contiguous layout. Useful for accepting inputs with stride information like numpy array or legate stores. The code is mostly copied and pasted from mdspan layout_left/right constructors. These constructors can optionally accept a stride layout if the underlying memory is contiguous, otherwise throw an exception. We change the exception into a boolean return value. Authors: - Jiaming Yuan (https://github.com/trivialfis) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#1861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for accepting inputs with stride information like numpy array or legate stores. The code is mostly copied and pasted from mdspan layout_left/right constructors. These constructors can optionally accept a stride layout if the underlying memory is contiguous, otherwise throw an exception. We change the exception into a boolean return value.