-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add bitset_filter
for CAGRA indices removal
#1837
[FEA] Add bitset_filter
for CAGRA indices removal
#1837
Conversation
Current benchmark performance on my local machine (with the corresponding
|
f21f826
to
d4067e2
Compare
/ok to test |
1 similar comment
/ok to test |
2165a6b
to
53b45dc
Compare
/ok to test |
Co-authored-by: Micka <[email protected]>
…g' into 23.10-cagra-remove
…g' into 23.10-cagra-remove
/ok to test |
Latest benchmark results on my local machine. The difference between
|
bitset_filter
for CAGRA indices removal
Current result of benchmark of bench-prims on 10M points, batch size 1, 10, 10lk
|
/ok to test |
|
/ok to test |
This PR fixes a bug in the filtering operations in the CAGRA multi-kernel search implementation. This bug caused the test of #1837 to fail. Authors: - tsuki (https://github.com/enp1s0) Approvers: - Micka (https://github.com/lowener) - Corey J. Nolet (https://github.com/cjnolet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@lowener, I've approved this PR and I think the implementation looks good. The only thing lacking now is documentation. We should add a separate usage example to |
/ok to test |
/ok to test |
Closes #1600.
To be merged after #1803 and #1811
This PR adds
bitset_filter
to filter an index with a bitset.