Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IVF-Flat C++ example #1828

Merged
merged 13 commits into from
Sep 26, 2023
Merged

Add IVF-Flat C++ example #1828

merged 13 commits into from
Sep 26, 2023

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Sep 18, 2023

This PR adds a C++ example program that demonstrate the usage of IVF-Flat vector search.

@tfeher tfeher added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search labels Sep 18, 2023
@tfeher tfeher self-assigned this Sep 18, 2023
@tfeher tfeher requested review from a team as code owners September 18, 2023 07:26
achirkin
achirkin approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 18, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@achirkin
Copy link
Contributor

/ok to test

@ajschmidt8
Copy link
Member

/ok to test

@ajschmidt8
Copy link
Member

/ok to test

For what it's worth, the first /ok to test comment above should have worked.

I checked the application logs and the GitHub API request was sent successfully and received a 200 response, but for whatever reason the https://github.com/rapidsai/raft/tree/pull-request/1828 branch was not actually updated.

Looks like this was a fluke on GitHub's end.

cjnolet
cjnolet requested changes Sep 20, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy to have these examples for users to reference. Mostly minor things, but want to make sure we're keeping the examples consistent (converting CAGRA to your example format shouldn't take much effort, AFAIK).

cpp/template/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Outdated Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Show resolved Hide resolved
cpp/template/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Outdated Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Outdated Show resolved Hide resolved
tfeher
tfeher commented Sep 21, 2023
View reviewed changes
Copy link
Contributor Author

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cjnolet for the good suggestions, I have updated the PR accordingly.

cpp/template/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/template/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Outdated Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Outdated Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Show resolved Hide resolved
cpp/template/src/ivf_flat_example.cu Outdated Show resolved Hide resolved
@tfeher tfeher mentioned this pull request Sep 22, 2023
Open
@cjnolet
Copy link
Member

cjnolet commented Sep 25, 2023

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Sep 25, 2023

@tfeher given how we want to get this in quickly for the blog, I think we can do the cmake change to expose the explicit instantiation as a follow-on in 23.12.

@cjnolet
Copy link
Member

cjnolet commented Sep 25, 2023

/merge

@cjnolet
Copy link
Member

cjnolet commented Sep 25, 2023

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Sep 25, 2023

/merge

@rapids-bot rapids-bot bot merged commit d4002b0 into rapidsai:branch-23.10 Sep 26, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achirkin achirkin achirkin approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@tfeher tfeher

Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tfeher @achirkin @ajschmidt8 @cjnolet