Fix raft-dask naming in wheel builds
#1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
requested changes
Sep 6, 2023
There was a problem hiding this comment.
This change mostly aligns with the fix we discussed, but I think you may have changed one too many places and you're going to run into some minor issues because of the way that some names get normalized. In particular, I think that the wheel names (like the actual filename) will still use raft_dask instead of raft-dask because that's the pip convention (convert hyphens to underscores). I could be wrong, but CI should reveal this for me. If you can test locally that might help you get through it faster so that you don't have to wait for pylibraft.
ajschmidt8
approved these changes
Sep 6, 2023
vyasr
approved these changes
Sep 6, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before https://github.com/rapidsai/raft/pull/1804/files, we were using
raft-daskandraft_daskinterchangeably because they were hardcoded. Since the package name is now capture as a variable, it's a bug to useraft_daskas the pyproject name does not get updated correctly and we end up publishingraft-daskwheels withoutcu{version}suffixes