Simplify wheel build scripts and allow alphas of RAPIDS dependencies #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
added
improvement
ajschmidt8
reviewed
Sep 6, 2023
Comment on lines
-9
to
-13
| RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})" | ||
|
|
||
| RAPIDS_PY_WHEEL_NAME=pylibraft_${RAPIDS_PY_CUDA_SUFFIX} rapids-download-wheels-from-s3 ./local-pylibraft | ||
| python -m pip install --no-deps ./local-pylibraft/pylibraft*.whl | ||
|
|
There was a problem hiding this comment.
Were these lines not necessary? If not, why?
There was a problem hiding this comment.
Yes, looks like I had copied them over from the previous workflows but raft-dask does not need pylibraft at build time
ajschmidt8
approved these changes
Sep 6, 2023
vyasr
approved these changes
Sep 6, 2023
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
#1804 missed updates for `ucx-py` to pick up alpha versioned nightlies Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Ray Douglass (https://github.com/raydouglass) URL: #1953
benfred
pushed a commit
to benfred/raft
that referenced
this pull request
Nov 8, 2023
rapidsai#1804 missed updates for `ucx-py` to pick up alpha versioned nightlies Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#1953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ci/apply_wheel_modifications.shand uses it inline in wheel build scripts