Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using expanded distance computations in pylibraft #1759

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Using expanded distance computations in pylibraft #1759

merged 8 commits into from
Aug 23, 2023

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Aug 21, 2023

We are noticing a perf hit of nearly 2x with the unexpanded distance computations vs the expanded sitances.

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Aug 21, 2023
@cjnolet cjnolet requested a review from a team as a code owner August 21, 2023 20:58
@cjnolet cjnolet self-assigned this Aug 21, 2023
@cjnolet cjnolet requested a review from a team as a code owner August 22, 2023 22:25
@github-actions github-actions bot added the cpp label Aug 22, 2023
@cjnolet
Copy link
Member Author

cjnolet commented Aug 23, 2023

/merge

@rapids-bot rapids-bot bot merged commit d5bd840 into rapidsai:branch-23.10 Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfred benfred benfred approved these changes

Assignees

@cjnolet cjnolet

Labels
bug Something isn't working cpp non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjnolet @benfred