Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add algo parameter for CAGRA ANN bench #1687

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Jul 27, 2023

To achieve high QPS with small batch size, it is recommended to use the multi_cta algorithm variant. CAGRA has an input parameter to specify which algorithm to use, but until now the benchmarks only used the default algorithm.

This PR adds configuration option for changing the algorithm parameter for the CAGRA ANN benchmark wrappers. This will be useful while benchmarking various configurations with CAGRA.

@tfeher tfeher added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search labels Jul 27, 2023
@tfeher tfeher self-assigned this Jul 27, 2023
@tfeher tfeher requested a review from a team as a code owner July 27, 2023 18:39
@github-actions github-actions bot added the cpp label Jul 27, 2023
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @tfeher!

@cjnolet
Copy link
Member

cjnolet commented Jul 27, 2023

/merge

@rapids-bot rapids-bot bot merged commit bcb7404 into rapidsai:branch-23.08 Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search
Projects
Development

Successfully merging this pull request may close these issues.

2 participants