Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing parameter for select_k #1682

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Fix missing parameter for select_k #1682

merged 3 commits into from
Jul 28, 2023

Conversation

ucassjy
Copy link
Contributor

@ucassjy ucassjy commented Jul 27, 2023

The parameter rmm::mr::device_memory_resource* mr is missing while passing down.

@rapids-bot
Copy link

rapids-bot bot commented Jul 27, 2023

Pull requests from external contributors require approval from a rapidsai organization member with write permissions or greater before CI can begin.

@github-actions github-actions bot added the cpp label Jul 27, 2023
@ahendriksen
Copy link
Contributor

/ok to test

@ahendriksen
Copy link
Contributor

/ok to test

@ucassjy ucassjy marked this pull request as ready for review July 28, 2023 02:18
@ucassjy ucassjy requested a review from a team as a code owner July 28, 2023 02:18
benfred
benfred approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm-thanks !

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Jul 28, 2023
@cjnolet
Copy link
Member

cjnolet commented Jul 28, 2023

/merge

@cjnolet
Copy link
Member

cjnolet commented Jul 28, 2023

/ok to test

@rapids-bot rapids-bot bot merged commit 47a4385 into rapidsai:branch-23.08 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfred benfred benfred approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ucassjy @ahendriksen @cjnolet @benfred