CAGRA Python wrappers #1665
Merged
CAGRA Python wrappers #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
tfeher
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Started to look at this, overall it looks nice, but had only a superficial view. From the current state of the API, it is not clear what is the use of the seprate build_knn_graph and optimize methods. They make sense if we can construct an index using their output. I have left a note at the index construction along this line.
cjnolet
requested changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First verstion of a CAGRA API in pylibraft.
Todos:
cagra_types.hppincluding#include <raft/util/pow2_utils.cuh>that makes it need nvcc, blocking a clean C++ only cython build