Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cagra ANN benchmark improvements #1658

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Jul 20, 2023

This PR improves CAGRA ANN benchmarks:

  • fixes search itopk parameter handling
  • adds more search and build parameters
  • improves logging

@tfeher tfeher added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search labels Jul 20, 2023
@tfeher tfeher self-assigned this Jul 20, 2023
@tfeher tfeher requested a review from a team as a code owner July 20, 2023 14:26
@github-actions github-actions bot added the cpp label Jul 20, 2023
1e-6;
const auto throughput = num_queries_done / time;

RAFT_LOG_INFO(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I have changed the build progress messages from DEBUG to INFO. Since build takes long (10+ min for large datasetst) I find it useful to get a message about the progress. This will emit 100 message during the build process. The DEBUG messages are be flooded by other IVF-PQ debug printouts, therefore I set this to INFO.

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Jul 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit 61f0d94 into rapidsai:branch-23.08 Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Vector Search
Projects
Development

Successfully merging this pull request may close these issues.

2 participants