Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sparse KNN for large batches #1640

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Fix sparse KNN for large batches #1640

merged 3 commits into from
Jul 26, 2023
+21 −17

Conversation

viclafargue
Copy link
Contributor

Answers #1187

@viclafargue viclafargue requested a review from a team as a code owner July 7, 2023 12:14
@github-actions github-actions bot added the cpp label Jul 7, 2023
tfeher
tfeher approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viclafargue for the PR, LGTM!

@tfeher
Copy link
Contributor

tfeher commented Jul 14, 2023

To resolve style errors, you could use pre-commit hooks

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (202385b) 87.98% compared to head (248dfe9) 87.98%.

Additional details and impacted files 
@@              Coverage Diff              @@
##           branch-23.08    #1640   +/-   ##
=============================================
  Coverage         87.98%   87.98%           
=============================================
  Files                21       21           
  Lines               491      491           
=============================================
  Hits                432      432           
  Misses               59       59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Jul 25, 2023
@cjnolet
Copy link
Member

cjnolet commented Jul 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit f25907b into branch-23.08 Jul 26, 2023
This was referenced Nov 20, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viclafargue @tfeher @codecov-commenter @cjnolet