-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable host dataset for IVF-Flat #1635
Merged
rapids-bot
merged 4 commits into
rapidsai:branch-24.02
from
tfeher:ivf_flat_host_dataset
Nov 28, 2023
Merged
Enable host dataset for IVF-Flat #1635
rapids-bot
merged 4 commits into
rapidsai:branch-24.02
from
tfeher:ivf_flat_host_dataset
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Jul 6, 2023
cjnolet
reviewed
Jul 20, 2023
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/ok to test |
/ok to test |
tfeher
force-pushed
the
ivf_flat_host_dataset
branch
from
November 20, 2023 11:20
806621c
to
81b79de
Compare
tfeher
force-pushed
the
ivf_flat_host_dataset
branch
from
November 20, 2023 11:34
81b79de
to
b0d3a42
Compare
Squashed the PR to a single commit to remove unsigned ones. |
cjnolet
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cpp
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Vector Search
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable host input data for IVF-Flat build.
This is done by batch-wise processing the dataset during extend, similarly how IVF-PQ does it.