Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test CI issues #1626

Merged
merged 9 commits into from
Jul 3, 2023
Merged

Conversation

VibhuJawa
Copy link
Member

No description provided.

@VibhuJawa VibhuJawa marked this pull request as ready for review June 29, 2023 23:38
@VibhuJawa VibhuJawa requested a review from a team as a code owner June 29, 2023 23:38
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 30, 2023
@cjnolet
Copy link
Member

cjnolet commented Jun 30, 2023

Looks like it's still skipping the tests. Darn. Tomorrow I'll attempt removing the conditional testing skipping based on the exception catching and see if it might be a dependency issue. Perhaps its also possible a dependency changed recently and maybe it was just coincidence it was around the time your changes were merged.

@VibhuJawa
Copy link
Member Author

@cjnolet , I think the issue was due to __init__.py and we are running into below. I am still trying to think what a long term good fix will be and why we are running into this problem.

    from raft_dask.common import (
common/__init__.py:16: in <module>
    from .comms import Comms, local_handle
common/comms.py:28: in <module>
    from .comms_utils import (
E   ModuleNotFoundError: No module named 'raft_dask.common.comms_utils'

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for finding/fixing this, @VibhuJawa!

@cjnolet
Copy link
Member

cjnolet commented Jul 3, 2023

/merge

@rapids-bot rapids-bot bot merged commit fda9cd1 into rapidsai:branch-23.08 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

2 participants