Use rapids-cmake new parallel testing feature #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
vyasr
requested changes
Jun 29, 2023
cpp/test/util/device_atomics.cu
Outdated
| // Copy data to host | ||
| RAFT_CUDA_TRY(cudaStreamSynchronize(s)); //ensure stream is done before copy |
There was a problem hiding this comment.
Could we use a cudaMemcpyAsync below instead?
There was a problem hiding this comment.
Yes we can, and done.
There was a problem hiding this comment.
Please use raft::copy and raft::update_host instead of calling cuda directly.
There was a problem hiding this comment.
There are no existing raft calls ( or handles ) in this test. The original version was calling cudaMemcpy on memory being written to by a kernel on a different stream.
Corrects multiple test issues uncovered by running tests in parallel. Splits the matrix and neighbor tests into multiple executables to improve throughput Previous performance on 1 GPU: 830sec New performance on 1 GPU: 692sec New performance on 2 GPU: 418sec
robertmaynard
force-pushed
the
fea/parallel_testing
branch
from
29e5659 to
aa0b622
Compare
vyasr
approved these changes
Jul 11, 2023
raydouglass
approved these changes
Jul 21, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects multiple test issues uncovered by running tests in parallel. Splits the matrix and neighbor tests into multiple executables to improve throughput
Previous performance on 1 GPU: 830sec
New performance on 1 GPU: 692sec
New performance on 2 GPU: 418sec