Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exceptions instead of exit(-1) #1594

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Use exceptions instead of exit(-1) #1594

merged 1 commit into from
Jun 21, 2023

Conversation

benfred
Copy link
Member

@benfred benfred commented Jun 19, 2023

Rather than exit the process immediately, use the RAFT_FAIL macro to throw an exception inside the cagra code when certain conditions aren't met

@benfred
Use exceptions instead of exit(-1)
6bcb0b3 
Rather than exit the process immediately, use the `RAFT_FAIL` macro
to throw an exception inside the cagra code when certain conditions
aren't met
@benfred benfred requested a review from a team as a code owner June 19, 2023 21:42
@github-actions github-actions bot added the cpp label Jun 19, 2023
@benfred benfred added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 19, 2023
tfeher
tfeher approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benfred far the changes, LGTM.

@benfred
Copy link
Member Author

benfred commented Jun 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit c69231e into rapidsai:branch-23.08 Jun 21, 2023
@benfred benfred deleted the no_exit branch June 21, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

Assignees
No one assigned
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benfred @tfeher