Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the CAGRA prune function to optimize #1588

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Rename the CAGRA prune function to optimize #1588

merged 5 commits into from
Jun 22, 2023

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented Jun 12, 2023

This PR renames the cagra::prune function to cagra::optimize since it adds reverse edges other than pruning unimportant edges.

@enp1s0 enp1s0 requested a review from a team as a code owner June 12, 2023 10:07
@github-actions github-actions bot added the cpp label Jun 12, 2023
@enp1s0 enp1s0 added improvement Improvement / enhancement to an existing function breaking Breaking change cpp and removed cpp labels Jun 12, 2023
@enp1s0
Copy link
Member Author

enp1s0 commented Jun 12, 2023

#1579

cjnolet
cjnolet approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Jun 22, 2023

/merge

@rapids-bot rapids-bot bot merged commit 28b61c4 into rapidsai:branch-23.08 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@enp1s0 enp1s0

Labels
breaking Breaking change cpp improvement Improvement / enhancement to an existing function
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enp1s0 @cjnolet