Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CAGRA knn_graph_sort to use Raft::bitonic_sort #1550

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Update CAGRA knn_graph_sort to use Raft::bitonic_sort #1550

merged 4 commits into from
Jun 2, 2023

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented May 29, 2023

This PR changes CAGRA knn_graph_sort function to use raft::util::bitnic_sort instead of a custom sorting function.

Rel: #1503 (comment)

@enp1s0 enp1s0 requested a review from a team as a code owner May 29, 2023 10:23
@enp1s0 enp1s0 self-assigned this May 29, 2023
@github-actions github-actions bot added the cpp label May 29, 2023
@enp1s0 enp1s0 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 29, 2023
@enp1s0
Copy link
Member Author

enp1s0 commented Jun 2, 2023

@tfeher Can you check the code and let me know if there are any problems?

@enp1s0 enp1s0 requested a review from tfeher June 2, 2023 08:14
tfeher
tfeher approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enp1s0 for these changes, the PR looks good to me. It is great to see more reuse of existing raft kernels.

@cjnolet
Copy link
Member

cjnolet commented Jun 2, 2023

/merge

@rapids-bot rapids-bot bot merged commit cfe27ec into rapidsai:branch-23.08 Jun 2, 2023
@tfeher tfeher mentioned this pull request Jul 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

Assignees

@enp1s0 enp1s0

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enp1s0 @cjnolet @tfeher