ivf-pq::search: fix the indexing type of the query-related mdspan arguments #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjnolet I'd like to squeeze this in 23.06 to have higher chances that nobody uses the original api. But this is a breaking change during burndown, so I surely don't mind moving it to 23.08 if you think it's more appropriate. |
|
@achirkin I'm okay putting this in 23.06. I'm sure it's fine but for completeness, can you please open a PR to test this change in cuml? |
cjnolet
approved these changes
May 20, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1357
breaking change: the type of argument mdspans has slightly changed (second template parameter fixed to
uint32_t)