-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename kernel arch finding function for dispatch #1536
Merged
rapids-bot
merged 82 commits into
rapidsai:branch-23.06
from
mdoijade:rename_dispatch_mechanism
May 19, 2023
Merged
Rename kernel arch finding function for dispatch #1536
rapids-bot
merged 82 commits into
rapidsai:branch-23.06
from
mdoijade:rename_dispatch_mechanism
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck/warp shape size, this now touches the perf of fusedL2NN simt kernel
… from per row to multi-rows. now this kernel is 1.3x to 1.8x faster as k value increases perf gets better than fusedL2NN simt kernel
… to predicated tile iterator
… than per warp multi row lock, cleanup and doc update
… tile iterator, this both improves perf by 20%+ compared to previous version by reducing gmem atomics+coalesced stores
…ing raft_cuda_try
…election, add comments on register spills tile shape, add test case for veclen=2
…fix cutlass_utils.h comments
…ing 2 copies of the same code
cjnolet
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- as the kernel arch given by the cudaFuncAttribute ptxVersion depends on what archs the kernel was compiled for
we should renam kernel_runtime_arch() as kernel_virtual_arch().
-- accordingly update comments to reflect this.