Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivf-flat: limit the workspace size of the search via batching #1515

Merged
merged 1 commit into from
May 16, 2023
Merged

ivf-flat: limit the workspace size of the search via batching #1515

merged 1 commit into from
May 16, 2023

Conversation

achirkin
Copy link
Contributor

closes #1343

@achirkin achirkin added bug Something isn't working non-breaking Non-breaking change labels May 16, 2023
@achirkin achirkin requested a review from a team as a code owner May 16, 2023 13:54
@github-actions github-actions bot added the cpp label May 16, 2023
@achirkin achirkin requested a review from tfeher May 16, 2023 13:58
tfeher
tfeher reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Artem for this fix! Just one question regarding the size heuristic.

cpp/include/raft/neighbors/detail/ivf_flat_search-inl.cuh Show resolved Hide resolved
tfeher
tfeher approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Artem for this fix! Just one question regarding the size heuristic.

cpp/include/raft/neighbors/detail/ivf_flat_search-inl.cuh Show resolved Hide resolved
@cjnolet
Copy link
Member

cjnolet commented May 16, 2023

/merge

@rapids-bot rapids-bot bot merged commit d99d249 into rapidsai:branch-23.06 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

Assignees

@achirkin achirkin

Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] IVF-FLAT OOM for large batch size
3 participants
@achirkin @cjnolet @tfeher