Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for cuda 12 issue in cusparse #1508

Merged

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented May 10, 2023

No description provided.

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels May 10, 2023
@cjnolet cjnolet self-assigned this May 10, 2023
@cjnolet cjnolet requested a review from a team as a code owner May 10, 2023 22:18
@github-actions github-actions bot added the cpp label May 10, 2023
@cjnolet
Copy link
Member Author

cjnolet commented May 10, 2023

/merge

@@ -241,6 +244,8 @@ struct sparse_matrix_t {
RAFT_CUSPARSE_TRY(raft::sparse::detail::cusparsespmv(
cusparse_h, trans, &alpha, matA, vecX, &beta, vecY, spmv_alg, external_buffer.raw(), stream));

// FIXME: This is a workaround for a cusparse issue being encountered in CUDA 12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link to a github issue for this problem that we can add here?

@cjnolet
Copy link
Member Author

cjnolet commented May 11, 2023

There's not but I'd like to add that in a follow-on. This PR is just applying a patch from Paul Taylor that we had to use for the DLFW containers to workaround a gnarly cuda bug. It's currently holding up cugraph.

@cjnolet
Copy link
Member Author

cjnolet commented May 11, 2023

Partially addresses #1509

@rapids-bot rapids-bot bot merged commit 2e73bda into rapidsai:branch-23.06 May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants