Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linalg::map to work with non-power-of-2-sized types again #1453

Merged
merged 10 commits into from
May 15, 2023
Merged

Fix linalg::map to work with non-power-of-2-sized types again #1453

merged 10 commits into from
May 15, 2023

Conversation

ahendriksen
Copy link
Contributor

@ahendriksen ahendriksen commented Apr 21, 2023 •
edited
Loading

Closes issue: #1413.

Adds back the ability for raft::linalg::map to work with non-power-of-2-sized types.

@github-actions github-actions bot added the cpp label Apr 21, 2023
@ahendriksen ahendriksen force-pushed the enh-fix-issue-1413 branch from a358aa7 to ebc19bc Compare May 4, 2023 13:14
@ahendriksen ahendriksen added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 4, 2023
@ahendriksen ahendriksen marked this pull request as ready for review May 4, 2023 13:35
@ahendriksen ahendriksen requested a review from a team as a code owner May 4, 2023 13:35
@ahendriksen ahendriksen changed the title [ENH] [WIP]: Attempt fix to non-pow2 linalg::map [ENH]: Fix to non-pow2 linalg::map May 4, 2023
@ahendriksen ahendriksen changed the title [ENH]: Fix to non-pow2 linalg::map [ENH]: Fix non-pow2 linalg::map May 4, 2023
@ahendriksen ahendriksen changed the title [ENH]: Fix non-pow2 linalg::map Fix linalg::map to work with non-power-of-2-sized types again May 4, 2023
divyegala
divyegala reviewed May 5, 2023
View reviewed changes
cpp/test/linalg/map.cu Outdated Show resolved Hide resolved
achirkin
achirkin requested changes May 10, 2023
View reviewed changes
cpp/include/raft/linalg/detail/map.cuh Outdated Show resolved Hide resolved
@achirkin achirkin linked an issue May 10, 2023 that may be closed by this pull request
[FEA] raft::linalg::map* primitives to support types that are not a power of 2 #1413
Closed
achirkin
achirkin approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@cjnolet
Copy link
Member

cjnolet commented May 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit 5524cb9 into rapidsai:branch-23.06 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala left review comments

@achirkin achirkin achirkin approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@ahendriksen ahendriksen

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] raft::linalg::map* primitives to support types that are not a power of 2
4 participants
@ahendriksen @cjnolet @achirkin @divyegala