Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing resource factory virtual destructor #1433

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Apr 19, 2023

Closes #1425

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Apr 19, 2023
@cjnolet cjnolet self-assigned this Apr 19, 2023
@cjnolet cjnolet requested a review from a team as a code owner April 19, 2023 16:58
@github-actions github-actions bot added the cpp label Apr 19, 2023
@cjnolet cjnolet added FAISS and removed cpp labels Apr 19, 2023
@cjnolet
Copy link
Member Author

cjnolet commented Apr 19, 2023

/merge

@rapids-bot rapids-bot bot merged commit 515ee5f into rapidsai:branch-23.06 Apr 19, 2023
ahendriksen pushed a commit to ahendriksen/raft that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FAISS non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

[BUG][RAFT+FAISS] Missing resource_factory virtual destructor
2 participants