Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nvtx3 includes. #1431

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Use nvtx3 includes. #1431

merged 1 commit into from
Apr 19, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 18, 2023

This PR updates raft to use #include <nvtx3/nvToolsExt.h> instead of #include <nvToolsExt.h>. This ensures we fetch the header-only NVTX v3. See NVTX docs for more information: https://nvidia.github.io/NVTX/#c-and-c

@bdice bdice requested a review from a team as a code owner April 18, 2023 20:37
@github-actions github-actions bot added the cpp label Apr 18, 2023
@benfred benfred added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 18, 2023
benfred
benfred approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@cjnolet
Copy link
Member

cjnolet commented Apr 19, 2023

/merge

@rapids-bot rapids-bot bot merged commit 6b021f5 into rapidsai:branch-23.06 Apr 19, 2023
ahendriksen pushed a commit to ahendriksen/raft that referenced this pull request Apr 27, 2023
@bdice @ahendriksen
Use nvtx3 includes. (rapidsai#1431)
91c152a 
This PR updates raft to use `#include <nvtx3/nvToolsExt.h>` instead of `#include <nvToolsExt.h>`. This ensures we fetch the header-only NVTX v3. See NVTX docs for more information: https://nvidia.github.io/NVTX/#c-and-c

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ben Frederickson (https://github.com/benfred)

URL: rapidsai#1431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfred benfred benfred approved these changes

Assignees

@bdice bdice

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @cjnolet @benfred