Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate pyproject dependencies with dfg #1364

Merged
merged 10 commits into from
Mar 23, 2023
Merged

Generate pyproject dependencies with dfg #1364

merged 10 commits into from
Mar 23, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 21, 2023

This PR uses dependencies.yaml to generate the dependency lists in pyproject.toml

@vyasr vyasr added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 21, 2023
@vyasr vyasr requested review from a team as code owners March 21, 2023 22:25
@vyasr vyasr self-assigned this Mar 21, 2023
vyasr
vyasr commented Mar 23, 2023
View reviewed changes
dependencies.yaml Outdated Show resolved Hide resolved
cjnolet
cjnolet approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question but otherwise it looks great. Pre-approving.

python/raft-dask/pyproject.toml Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Mar 23, 2023

/merge

@rapids-bot rapids-bot bot merged commit 419f0c2 into rapidsai:branch-23.04 Mar 23, 2023
@vyasr vyasr deleted the feat/pyproject_dependencies branch March 23, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @cjnolet @ajschmidt8