Pass AWS_SESSION_TOKEN and SCCACHE_S3_USE_SSL vars to conda build
#1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
added
the
improvement
raydouglass
approved these changes
Mar 8, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
AWS_SESSION_TOKENandSCCACHE_S3_USE_SSLenvironment variables are passed to our conda build process.AWS_SESSION_TOKENis necessary in order to support using temporary credentials via AWS STS (we recently adopted this method in CI).SCCACHE_S3_USE_SSLhas been reported to increase cache performance for S3.