Consolidate linter configuration into pyproject.toml #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
improvement
benfred
approved these changes
Mar 9, 2023
|
/merge |
lowener
pushed a commit
to lowener/raft
that referenced
this pull request
Mar 15, 2023
raft currently stores config information for linters across many different pyproject.toml and setup.cfg files. This PR moves all linter configuration out of setup.cfg files into pyproject.toml where possible. flake8 does not support pyproject.toml, so that data is placed in the flake8-specific .flake8 file. Old and unused .flake8 files have been removed. These changes are a precursor to build system migrations that should allow further consolidation of the data in these files. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Ben Frederickson (https://github.com/benfred) URL: rapidsai#1317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raft currently stores config information for linters across many different pyproject.toml and setup.cfg files. This PR moves all linter configuration out of setup.cfg files into pyproject.toml where possible. flake8 does not support pyproject.toml, so that data is placed in the flake8-specific .flake8 file. Old and unused .flake8 files have been removed. These changes are a precursor to build system migrations that should allow further consolidation of the data in these files.