Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IVF-Flat Python wrappers #1316

Merged
merged 37 commits into from
Mar 17, 2023
Merged

IVF-Flat Python wrappers #1316

merged 37 commits into from
Mar 17, 2023

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Mar 7, 2023

Add Python wrappers to IVF-Flat.

closes #1139

It also adds a C++ interface to raft_runtime, that is called from Cython wrappers. The corresponding specializations are defined, but not used elsewhere (see #1238).

@tfeher
Copy link
Contributor Author

tfeher commented Mar 7, 2023 •
edited by divyegala
Loading

Todo:

  • debug passing mdarrays to build/search
  • serialization
  • Python tests

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 7, 2023
@divyegala divyegala marked this pull request as ready for review March 9, 2023 18:05
@divyegala divyegala requested review from a team as code owners March 9, 2023 18:05
cjnolet
cjnolet reviewed Mar 9, 2023
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member

cjnolet commented Mar 9, 2023

@divyegala just noting here that it'll probably be easier to change uint64_t -> int64_t after this is merged, since I've already scraped through the cython/python and changed the mdspans everywhere in pylibraft/common/mdspan.pyx

@divyegala divyegala mentioned this pull request Mar 14, 2023
Merged
cjnolet
cjnolet approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet
Copy link
Member

cjnolet commented Mar 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit 7074010 into rapidsai:branch-23.04 Mar 17, 2023
@tfeher tfeher deleted the fea-ivf-flat-python-api branch October 25, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala left review comments

@cjnolet cjnolet cjnolet approved these changes

Assignees

@tfeher tfeher

@divyegala divyegala

Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Python API for IVF-Flat
4 participants
@tfeher @cjnolet @divyegala @viclafargue