Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary buffer to view host or device memory in device #1313

Merged
merged 12 commits into from
Mar 8, 2023
Merged

Temporary buffer to view host or device memory in device #1313

merged 12 commits into from
Mar 8, 2023

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Mar 1, 2023 •
edited
Loading

closes #1299

@github-actions github-actions bot added the cpp label Mar 1, 2023
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 1, 2023
cjnolet
cjnolet requested changes Mar 2, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far. Just a couple small notes

cpp/include/raft/core/device_buffer.hpp Outdated Show resolved Hide resolved
cpp/test/core/mdarray.cu Outdated Show resolved Hide resolved
cpp/include/raft/core/device_buffer.hpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the CMake label Mar 6, 2023
@divyegala divyegala marked this pull request as ready for review March 6, 2023 17:31
@divyegala divyegala requested review from a team as code owners March 6, 2023 17:31
wphicks
wphicks approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one suggestion to clarify docs.

cpp/include/raft/core/temporary_device_buffer.hpp Outdated Show resolved Hide resolved
@divyegala divyegala requested a review from cjnolet March 7, 2023 14:00
cjnolet
cjnolet approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs and usage examples look great. I think this is ready to go. Very nice to also see the container policy being reused here too.

@divyegala
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 206611c into rapidsai:branch-23.04 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@divyegala divyegala

Labels
5 - Ready to Merge CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] mdspan/mdarray-based utility to copy a pointer to device iff it is not already on device
3 participants
@divyegala @cjnolet @wphicks