Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API for brute-force KNN #1292

Merged
merged 114 commits into from
Mar 23, 2023
Merged

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 21, 2023

Closes #1289

benfred and others added 30 commits January 27, 2023 11:03
Replace faiss bfKnn with code that leverages our pairwise_distance api
and select_k api - by computing tiling over the inputs.

This lets us remove faiss as a dependency
This reverts commit 8eaba84.

Change didn't seem to build in CI
Also remove metrics processors - since is handled inside PW distance
This reverts commit fe728e9.

This is causing incorrect results, just use the faiss select_k call
instead
@github-actions github-actions bot added the ci label Mar 17, 2023
@cjnolet
Copy link
Member Author

cjnolet commented Mar 20, 2023

Cross-linking comment on these changes from @vyasr in other PR: #1333 (comment).

@cjnolet cjnolet marked this pull request as ready for review March 23, 2023 01:35
@cjnolet cjnolet requested review from a team as code owners March 23, 2023 01:35
@dantegd dantegd mentioned this pull request Mar 23, 2023
4 tasks
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I'm excited to see this functionality go in

python/pylibraft/pylibraft/neighbors/brute_force.pyx Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Mar 23, 2023

/merge

@rapids-bot rapids-bot bot merged commit 31847af into rapidsai:branch-23.04 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

[FEA] Expose brute-force knn through pylibraft
2 participants