@vyasr have you verified that this fix works for you to fix the symbol lookup error in cuml? I'm kind of surprised cuml is using these symbols at the moment and hasn't failed until now, but it makes sense that it would happen.

I'm testing it in this cuml PR. I don't think that cuml is using these anywhere important because conda CI is fine, but due to the raft rebuild + static linking happening for wheels I think the symbols are being searched.

Ah, okay. So I take it cuml's CI does fail without the change? (I thought someone had mentioned they didn't see the failures in cuml's CI)

I think I was updating my previous comment while you responded 😂 so to reiterate, we see these failures only for wheels, not conda. That's probably because as you suspect cuml isn't actually using these symbols, but they are problematic when raft is rebuilt in the wheels CI for cuml and then statically linked to as though the symbols should exist.

@vyasr got it. Also making a note here that I believe @achirkin recently found some of the ivfpq specializations were no longer being used within RAFT, which was adding some unecessary build time. That should be fixed soon too (and should help speed up the build a bit). :-)

/merge

Also making a note here that I believe @achirkin recently found some of the ivfpq specializations were no longer being used within RAFT, which was adding some unecessary build time. That should be fixed soon too (and should help speed up the build a bit). :-)

I'm afraid, on the contrary: I've made the specializations (copmute_similarity kernel) be used again (by ivf_pq::search). This does improve the compile times though :)

I'm afraid, on the contrary: I've made the specializations (copmute_similarity kernel) be used again (by ivf_pq::search). This does improve the compile times though :)

This is what I meant- you found specializations which were no longer being used in the tests and benchmarks, causing unecessary compile times and you are fixing them by having them use the specializations again. Sorry for being confusing there.