-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IVF-Flat index splitting #1271
IVF-Flat index splitting #1271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lowener for the PR, it looks great overall! I have just a few comments to add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
/merge |
Refactor of `ivf_flat::index` to split the cluster data in separate buffers - Addressing rapidsai#1170. - Following rapidsai#1249 in the index structure implementation. - Adding serialization API with stream and filename overloads - Moving `raft::spatial::knn::ivf_flat` namespace to `raft::neighbors::ivf_flat` Authors: - Micka (https://github.com/lowener) - Corey J. Nolet (https://github.com/cjnolet) - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - AJ Schmidt (https://github.com/ajschmidt8) - Artem M. Chirkin (https://github.com/achirkin) URL: rapidsai#1271
Refactor of
ivf_flat::index
to split the cluster data in separate buffersraft::spatial::knn::ivf_flat
namespace toraft::neighbors::ivf_flat