Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: Update isort version to 5.12.0 #1215

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jan 31, 2023

poetry version 1.5.0 broke installs of isort prior to 5.11.5 (see PyCQA/isort#2077 and PyCQA/isort#2078), so we need to upgrade.

poetry version 1.5.0 broke installs of isort prior to 5.11.5 (see
PyCQA/isort#2077 and PyCQA/isort#2078), so we need to upgrade.
@wence-
Copy link
Contributor Author

wence- commented Jan 31, 2023

In line with the same changes across the rest of rapids. This fixes creation of new pre-commit environments.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2023
@cjnolet cjnolet requested a review from benfred January 31, 2023 14:46
@cjnolet
Copy link
Member

cjnolet commented Jan 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 4f33aab into rapidsai:branch-23.02 Jan 31, 2023
@wence- wence- deleted the wence/fix/pre-commit-isort branch January 31, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants