Pin wheel dependencies to same RAPIDS release #1200
Conversation
sevagh
added
non-breaking
ci/release/update-version.sh
Outdated
| sed_runner "s/${CURRENT_SHORT_TAG_PEP440}/${NEXT_SHORT_TAG_PEP440}/g" python/pylibraft/setup.py | ||
| sed_runner "s/${CURRENT_SHORT_TAG_PEP440}/${NEXT_SHORT_TAG_PEP440}/g" python/pylibraft/_custom_build/backend.py | ||
| sed_runner "s/${CURRENT_SHORT_TAG_PEP440}/${NEXT_SHORT_TAG_PEP440}/g" python/raft-dask/setup.py | ||
| sed_runner "s/${CURRENT_UCX_PY_VERSION_PEP440}/${NEXT_UCX_PY_VERSION_PEP440}/g" python/raft-dask/setup.py |
There was a problem hiding this comment.
I think it's best to avoid using any kind of CURRENT_SHORT_TAG reference in the search term for these lines because if the source files become out of sync (which happens occasionally) then these sed commands will fail.
I would recommend making the search terms more specific.
There was a problem hiding this comment.
BTW, you can test these lines with commands like: bash ci/release/update-version.sh 23.04.00.
I usually try to run a sequence of commands like this to ensure that everything works as expected:
bash ci/release/update-version.sh 23.06.00
bash ci/release/update-version.sh 22.06.00
bash ci/release/update-version.sh 23.02.00
Codecov ReportBase: 87.99% // Head: 87.99% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1200 +/- ##
=============================================
Coverage 87.99% 87.99%
=============================================
Files 21 21
Lines 483 483
=============================================
Hits 425 425
Misses 58 58 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
… into upkeep/pin-rapids-wheel-deps
|
/merge |
Now that wheel CI is enabled, the nightly index will contain next release wheels, so we need to ensure those don't get installed while still building this release.
Also tests a new mechanism (
local-wheelhouse) for cibuildwheel to prefer local wheels.