Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IVF-Flat bug fix: the *squared* norm is required for expanded distance calculations #1141

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

Nyrio
Copy link
Contributor

@Nyrio Nyrio commented Jan 13, 2023

No description provided.

@Nyrio Nyrio requested a review from a team as a code owner January 13, 2023 15:15
@Nyrio Nyrio self-assigned this Jan 13, 2023
@github-actions github-actions bot added the cpp label Jan 13, 2023
@Nyrio Nyrio added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Jan 13, 2023
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nyrio for finding and fixing the bug! LGTM

achirkin added a commit to achirkin/raft that referenced this pull request Jan 13, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 87.99% // Head: 87.99% // No change to project coverage 👍

Coverage data is based on head (f70d8a3) compared to base (36b315d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #1141   +/-   ##
=============================================
  Coverage         87.99%   87.99%           
=============================================
  Files                21       21           
  Lines               483      483           
=============================================
  Hits                425      425           
  Misses               58       58           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member

cjnolet commented Jan 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit dde7c53 into rapidsai:branch-23.02 Jan 13, 2023
@Nyrio
Copy link
Contributor Author

Nyrio commented Jan 15, 2023

@cjnolet You lost one of the changes while solving conflicts with @benfred's #1133. Fix in #1144

rapids-bot bot pushed a commit that referenced this pull request Jan 15, 2023
This change was part of #1141 but was accidentally lost while merging conflicts with #1133

Authors:
  - Louis Sugy (https://github.com/Nyrio)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

5 participants