Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to use an existing stream in the pylibraft Handle #1125

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Adding ability to use an existing stream in the pylibraft Handle #1125

merged 5 commits into from
Jan 9, 2023

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jan 6, 2023

Closes #1123

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 6, 2023
@cjnolet cjnolet marked this pull request as ready for review January 6, 2023 23:26
@cjnolet cjnolet requested a review from a team as a code owner January 6, 2023 23:26
@github-actions github-actions bot added the python label Jan 6, 2023
@cjnolet cjnolet mentioned this pull request Jan 6, 2023
Closed
@cjnolet cjnolet self-assigned this Jan 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023 •
edited
Loading

Codecov Report

Base: 87.68% // Head: 87.68% // No change to project coverage 👍

Coverage data is based on head (4255c28) compared to base (9944b3a).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@              Coverage Diff              @@
##           branch-23.02    #1125   +/-   ##
=============================================
  Coverage         87.68%   87.68%           
=============================================
  Files                20       20           
  Lines               471      471           
=============================================
  Hits                413      413           
  Misses               58       58

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dantegd
dantegd requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had some very small questions/comments

python/pylibraft/pylibraft/common/handle.pyx Outdated Show resolved Hide resolved
python/pylibraft/pylibraft/test/test_distance.py Show resolved Hide resolved
python/pylibraft/pylibraft/common/handle.pyx Show resolved Hide resolved
@cjnolet cjnolet requested a review from a team as a code owner January 9, 2023 17:57
@github-actions github-actions bot added the cpp label Jan 9, 2023
@cjnolet
Copy link
Member Author

cjnolet commented Jan 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit 53ba226 into rapidsai:branch-23.02 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees

@cjnolet cjnolet

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
3 participants
@cjnolet @codecov-commenter @dantegd