Remove faiss ANN code from knnIndex #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfred
added
improvement
Codecov ReportBase: 87.99% // Head: 87.99% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1121 +/- ##
=============================================
Coverage 87.99% 87.99%
=============================================
Files 21 21
Lines 483 483
=============================================
Hits 425 425
Misses 58 58 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
benfred
added a commit
to benfred/cuml
that referenced
this pull request
Jan 19, 2023
|
/merge |
benfred
added a commit
to benfred/cuml
that referenced
this pull request
Jan 20, 2023
This reverts commit c1a6cd1.
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jan 20, 2023
We are removing the faiss ANN code in rapidsai/raft#1121, in favour of using the ivf_flat and ivf_pq implementations included with raft. After this change, RAFT can be updated to remove the faiss ANN methods - which is implemented in rapidsai/raft#1121 Note that this removes the `ivf_sq` option , since there is no corresponding implementation in raft. Closes #5131 Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #5119
ahendriksen
pushed a commit
to ahendriksen/raft
that referenced
this pull request
Jan 23, 2023
Authors: - Ben Frederickson (https://github.com/benfred) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1121
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
We are removing the faiss ANN code in rapidsai/raft#1121, in favour of using the ivf_flat and ivf_pq implementations included with raft. After this change, RAFT can be updated to remove the faiss ANN methods - which is implemented in rapidsai/raft#1121 Note that this removes the `ivf_sq` option , since there is no corresponding implementation in raft. Closes rapidsai#5131 Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#5119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.