Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels alongside conda CI #1116

Merged
merged 37 commits into from
Jan 13, 2023
Merged

Build wheels alongside conda CI #1116

merged 37 commits into from
Jan 13, 2023

Conversation

sevagh
Copy link
Contributor

@sevagh sevagh commented Dec 21, 2022

This PR adds pip wheel CI to the Conda CI, instead of having them work separately.

@sevagh sevagh requested a review from a team as a code owner December 21, 2022 21:13
@sevagh sevagh added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Base: 87.99% // Head: 87.99% // No change to project coverage 👍

Coverage data is based on head (298242b) compared to base (36b315d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #1116   +/-   ##
=============================================
  Coverage         87.99%   87.99%           
=============================================
  Files                21       21           
  Lines               483      483           
=============================================
  Hits                425      425           
  Misses               58       58           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet cjnolet self-assigned this Jan 3, 2023
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Jan 9, 2023

@sevagh to fix the raft-dask NCCL issue during the CMake configure, after this line add

find_package(NCCL REQUIRED)

@sevagh sevagh requested a review from a team as a code owner January 9, 2023 18:39
sevagh added a commit to rapidsai/shared-workflows that referenced this pull request Jan 9, 2023
Create new wheel build parameters: `before-wheel`

This allows us to use `rapids-download-wheels-from-s3` to have
inter-dependent wheels within a single workflow download the dependency
wheels _built in this current workflow run_ instead of pulling the
nightly published copy.

Tested for pure wheels in cuDF:
rapidsai/cudf#12427
Tested for manylinux wheels in RAFT:
rapidsai/raft#1116
@vyasr vyasr requested a review from a team as a code owner January 11, 2023 06:02
@github-actions github-actions bot added the ci label Jan 11, 2023
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@vyasr
Copy link
Contributor

vyasr commented Jan 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit 7e5ce78 into rapidsai:branch-23.02 Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

5 participants