Decoupling raft handle from underlying resources #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
getting "killed" on cleanup it seems.
itkeeps dying for me locally
…couple_handle_resources
Codecov ReportBase: 87.68% // Head: 87.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1111 +/- ##
================================================
+ Coverage 87.68% 87.99% +0.30%
================================================
Files 20 21 +1
Lines 471 483 +12
================================================
+ Hits 413 425 +12
Misses 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wphicks
requested changes
Jan 4, 2023
benfred
reviewed
Jan 4, 2023
dantegd
approved these changes
Jan 4, 2023
divyegala
reviewed
Jan 4, 2023
achirkin
reviewed
Jan 9, 2023
…et/raft into fea-2302-decouple_handle_resources
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a design idea a few of us have been kicking around for a little while now to help decouple underlying resources from the raft handle and also allow users to never have to explicitly include headers for resources that are never used (such as cublas, cusolver, cusparse, comms, etc...).
This effectively breaks the existing raft::handle_t into separate headers for the various resources it contains, providing functions that can be individually included and invoked on a
raft::resources. This still allows us to write something like araft::device_resources(and also allows us to maintain API compatibility in the meantime by backing the existingraft::handle_twith araft::resources.One of the major goals of this PR is to also enable a handle to be used outside of just cuda resources and to allow for unused resources to not need to be loaded nor compiled at all into user code downstream.
Follow-on work after this PR will include:
raft::resourcesand using the individual resource accessors instead of assumingdevice_resourceseverywhere.handle_tin favor of the more explicitdevice_resources