Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing an index error introduced in PR #1109 #1110

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Fixing an index error introduced in PR #1109 #1110

merged 1 commit into from
Dec 21, 2022

Conversation

vinaydes
Copy link
Contributor

My PR #1109 has an index error, pointed out by @benfred in this comment.

@vinaydes vinaydes requested a review from a team as a code owner December 17, 2022 12:27
@github-actions github-actions bot added the cpp label Dec 17, 2022
benfred
benfred approved these changes Dec 17, 2022
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - thanks !

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 17, 2022
@cjnolet
Copy link
Member

cjnolet commented Dec 21, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0612284 into rapidsai:branch-23.02 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@benfred benfred benfred approved these changes

Assignees

@vinaydes vinaydes

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinaydes @cjnolet @benfred